raphinesse commented on a change in pull request #859: Removed unnecessary
project name restriction
URL: https://github.com/apache/cordova-android/pull/859#discussion_r344134852
##########
File path: bin/lib/create.js
##########
@@ -225,11 +225,6 @@ function validateProjectName (project_name) {
return Q.reject(new CordovaError(msg + 'Project name cannot be
CordovaActivity'));
Review comment:
If this name is not used as a class name, then this check would probably be
superfluous too, right? And that would mean this whole function basically
degenerates to a check if `project_name` is truthy. Which means it could be
removed altogether.
_Note_: I'm just extrapolating based on the information you gave in the PR
description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
