raphinesse commented on a change in pull request #744: chore: updated eslint 
with applied fix
URL: https://github.com/apache/cordova-ios/pull/744#discussion_r359028592
 
 

 ##########
 File path: package.json
 ##########
 @@ -29,18 +29,12 @@
     "xcodebuild": "xcodebuild -quiet test -workspace 
tests/cordova-ios.xcworkspace -destination \"platform=iOS Simulator,name=iPhone 
8\" CONFIGURATION_BUILD_DIR=\"`mktemp -d 2>/dev/null || mktemp -d -t 
'cordova-ios'`\"",
     "preobjc-tests": "tests/scripts/killsim.js",
     "unit-tests": "jasmine --config=tests/spec/unit.json",
-    "eslint": "eslint . \"bin/**/!(*.*)\""
+    "lint": "eslint ."
 
 Review comment:
   ```suggestion
       "lint": "eslint . \"bin/**/!(*.*)\""
   ```
   
   The deleted part is needed to lint the JS "binaries" that have no `.js` 
extension.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to