This is an automated email from the ASF dual-hosted git repository.

erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-electron.git


The following commit(s) were added to refs/heads/master by this push:
     new 617b87f  refactor: transform object shorthand (#122)
617b87f is described below

commit 617b87f39349002d55e29803c3aee8a986d753f6
Author: エリス <[email protected]>
AuthorDate: Fri Dec 20 06:50:15 2019 +0900

    refactor: transform object shorthand (#122)
---
 bin/templates/cordova/Api.js                       |  2 +-
 .../spec/unit/templates/cordova/lib/build.spec.js  | 54 +++++++++++-----------
 2 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/bin/templates/cordova/Api.js b/bin/templates/cordova/Api.js
index 1ca3a11..5ee2677 100644
--- a/bin/templates/cordova/Api.js
+++ b/bin/templates/cordova/Api.js
@@ -59,7 +59,7 @@ class Api {
         this.handler = require('./handler');
 
         this.locations = {
-            platformRootDir: platformRootDir,
+            platformRootDir,
             root: this.root,
             www: path.join(this.root, 'www'),
             res: path.join(this.root, 'res'),
diff --git a/tests/spec/unit/templates/cordova/lib/build.spec.js 
b/tests/spec/unit/templates/cordova/lib/build.spec.js
index d05f53c..6b24b98 100644
--- a/tests/spec/unit/templates/cordova/lib/build.spec.js
+++ b/tests/spec/unit/templates/cordova/lib/build.spec.js
@@ -119,7 +119,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: true, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: true, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -146,7 +146,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -173,7 +173,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(false);
@@ -205,7 +205,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -341,7 +341,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: true, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: true, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -502,7 +502,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -556,7 +556,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: true, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: true, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -608,7 +608,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -640,7 +640,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -672,7 +672,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -716,7 +716,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -762,7 +762,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -812,7 +812,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -892,7 +892,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: true, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: true, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -986,7 +986,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: true, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: true, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -1061,7 +1061,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: true, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: true, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -1126,7 +1126,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: true, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: true, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(true);
@@ -1213,7 +1213,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(false);
@@ -1245,7 +1245,7 @@ describe('Testing build.js:', () => {
             };
 
             // config.mas is appeneded to build options to spoof what 
__formatAppendUserSettings method would have performed.
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [], config: { mas: {} } };
+            const buildOptions = { debug: false, buildConfig, argv: [], 
config: { mas: {} } };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(false);
@@ -1273,7 +1273,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             // create spies
             existsSyncSpy = 
jasmine.createSpy('existsSync').and.returnValue(false);
@@ -1300,7 +1300,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             const config = {
                 debug: 'debug',
@@ -1343,7 +1343,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             const config = {
                 debug: 'debug',
@@ -1406,7 +1406,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             const config = {
                 debug: 'debug',
@@ -1469,7 +1469,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             const config = {
                 debug: 'debug',
@@ -1515,7 +1515,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             const config = {
                 debug: 'debug',
@@ -1563,7 +1563,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             const config = {
                 debug: 'debug',
@@ -1608,7 +1608,7 @@ describe('Testing build.js:', () => {
                 APP_WWW_DIR: api.locations.www
             };
 
-            const buildOptions = { debug: false, buildConfig: buildConfig, 
argv: [] };
+            const buildOptions = { debug: false, buildConfig, argv: [] };
 
             const config = {
                 debug: 'debug',


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to