This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch brodybits-uwp-only-test-wip0201 in repository https://gitbox.apache.org/repos/asf/cordova-windows.git
commit fca282cf6f732d4dd63a253da66be5254c8be2e4 Author: Christopher J. Brody <[email protected]> AuthorDate: Sun Dec 22 14:53:15 2019 -0500 Remove support for VS 14 (Visual Studio 2015) with an updated error message and update a comment regarding the Visual Studio build tooling Co-authored-by: Jan Piotrowski <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]> --- template/cordova/lib/MSBuildTools.js | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/template/cordova/lib/MSBuildTools.js b/template/cordova/lib/MSBuildTools.js index 68ea01d..4c09563 100644 --- a/template/cordova/lib/MSBuildTools.js +++ b/template/cordova/lib/MSBuildTools.js @@ -260,12 +260,8 @@ var projFiles = { win10: 'CordovaApp.Windows10.jsproj' }; -// TODO: Fix this so that it outlines supported versions based on version criteria: -// - v14: Windows 8.1, Windows 10 -// - v12: Windows 8.1 -function msBuild14TargetsFilter (target) { - return target === projFiles.win || target === projFiles.phone || target === projFiles.win10; -} +// NOTE: build tools starting with v15 target Windows 10 +// (UWP for Windows 10 desktop and mobile) only. function msBuild15TargetsFilter (target) { return target === projFiles.win || target === projFiles.phone || target === projFiles.win10; @@ -283,7 +279,6 @@ function filterSupportedTargets (targets, msbuild) { } var targetFilters = { - '14.0': msBuild14TargetsFilter, '15.x': msBuild15TargetsFilter, '15.5': msBuild155TargetsFilter, get: function (version) { @@ -303,8 +298,7 @@ function filterSupportedTargets (targets, msbuild) { // unsupported targets have been detected if (supportedTargets.length !== targets.length) { events.emit('warn', 'Not all desired build targets are compatible with the current build environment. ' + - 'Please install Visual Studio 2015 for Windows 8.1 and Windows 10, ' + - 'or Visual Studio 2013 Update 2 for Windows 8.1.'); + 'Please install Visual Studio 2017.'); } return supportedTargets; } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
