NiklasMerz commented on a change in pull request #584: feat: Add compile-time
decision for disabling UIWebView
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/584#discussion_r362637477
##########
File path: src/ios/CDVInAppBrowser.m
##########
@@ -49,86 +51,122 @@ - (void)open:(CDVInvokedUrlCommand*)command
return;
}
self.usewkwebview = browserOptions.usewkwebview;
- if(self.usewkwebview){
- [[CDVWKInAppBrowser getInstance] open:command];
- }else{
- [[CDVUIInAppBrowser getInstance] open:command];
- }
+ #if WK_WEB_VIEW_ONLY
Review comment:
I am not a fan of this build flag, too. It is kind of ugly and hard to get
while reading this code (for non-objective-c devs) but I think it is great for
an interim solution until #535 gets released in a **major** release hopefully
soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
