DRK1004 commented on issue #584: feat: Add compile-time decision for disabling UIWebView URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/584#issuecomment-571007698 Its great that new version of this plugin is released, as it was much awaited thing. But while taking a look on the changes, I observed below change, which seems incorrect to me. ``` - (void)injectScriptFile:(CDVInvokedUrlCommand*)command { #if WK_WEB_VIEW_ONLY [[CDVWKInAppBrowser getInstance] injectScriptCode:command]; #else if(self.usewkwebview){ [[CDVWKInAppBrowser getInstance] injectScriptCode:command]; }else{ [[CDVUIInAppBrowser getInstance] injectScriptCode:command]; } #endif } ``` Let me know if below code is fine or its a copy paste mistake.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
