sithwarrior commented on issue #171: Added ANDROID_GPS_REQUIRED parameter for optional GPS URL: https://github.com/apache/cordova-plugin-geolocation/pull/171#issuecomment-571205716 > > This is nice, would fix #187 nicely, however default `false` would be even better > > Defaulting to `false` would be a breaking change. Which I would like to avoid. I fail to see how this is breaking? Apps become available to non GPS hardware on Android, thats the change. Apps are already available to non GPS hardware on iOS with this plugin, ie iPod Touch. Its a change, but again, I dont think its breaking. You are never guaranteed location data in you app anyway, as it might be disabled by the user. If its deemed breaking, I still think false should be default, but of course the plugin would need a major version bump. Im not trying to be rude, just getting my opinion across. :) keep up the good work.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
