timbru31 commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r364868814
##########
File path: bin/templates/project/app/build.gradle
##########
@@ -291,6 +300,11 @@ android {
dependencies {
implementation fileTree(dir: 'libs', include: '*.jar')
+
+ if (cdvHelpers.getConfigPreference('EnableKotlin', 'false').toBoolean()) {
+ compile "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
Review comment:
Why do we require the `jdk7` stdlib here? This should be changed to
`kotlin-stdlib` instead.
```suggestion
compile "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
