breautek commented on issue #171: Added ANDROID_GPS_REQUIRED parameter for optional GPS URL: https://github.com/apache/cordova-plugin-geolocation/pull/171#issuecomment-573421659 > To reflect the fact that this setting applies only to the Android platform, I added the ANDROID prefix to the variable. Just to make sure iOS developers don't get confused with it. I understand your reasoning, but there are many preferences that only apply to a specific platform, some of them eventually made their way to be supported on other platforms. Rarely cordova preferences uses a platform-prefix preference style, and instead the supported platforms are documented. And I think that pattern should be maintained, because otherwise it can be hard to change in the future, should the flag need to be applied to another platform. The only time cordova uses a platform-prefix is when there is reasonable belief that preference is guaranteed to only ever apply to a specific platform, such as `android-minSdkVersion` preference. `AllowInlineMediaPlayback` is an example of an iOS only preference with no platform prefix, because that preference may be required or make sense to be used by another platform in the future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
