erisu opened a new pull request #896: dFeat/kotlin support
URL: https://github.com/apache/cordova-android/pull/896
 
 
   ### Motivation and Context
   
   To finish off the change requests and close out PR #441
   
   closes: #441
   
   ### Description
   
   What this PR does:
   
   * Cherry-picks commit changes from #441
   * Rename preference option `EnableKotlin` to `KotlinEnabled` (Default: 
`false`)
     * Since the preference has not been released or used in any other repos, 
the name change is safe. This change is only an update from the original PR's 
proposal.
   * Added preference options `KotlinCodeStyle` (Default: `official`)
   * Added preference option `KotlinVersion` (Default: `1.3.41`)
   * Apply `kotlin-android-extensions` plugin as well when `EnableKotlin` is 
`true`
   * Changed `compile` to `implementation`
   
   ### Testing
   
   - `npm t`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary (*Pending Work for Cordova 
Docs Repo*)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to