erisu edited a comment on issue #780: breaking: upgrade xcode compatible to 11.0 URL: https://github.com/apache/cordova-ios/pull/780#issuecomment-584919931 The changes in this PR were made though the Xcode interface. Nothing was manually changed except to re-add back quotation wrappers around the product name for UTF-8 support. I believe `LastUpgradeCheck` shouldn't be manually changed. Xcode should have updated it if it was needed. I am guessing that Xcode did not change `LastUpgradeCheck` because it was not triggered by an upgrade notification. If we manually changed it, we would need to know the correct value. * What would be the side-effect of changing it manually? * If not everything was upgraded and it was manually changed, would it be basically be disabling the flag that Xcode might used to determining to display an upgrade notification? And if disabled and if there were missed changes, would they not be corrected? Anyways, I think it is safe to keep it as is and wait till next time Xcode automatically updates this for us.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
