knight9999 commented on a change in pull request #781: breaking: Use
WKURLSchemeHandler for serving app content
URL: https://github.com/apache/cordova-ios/pull/781#discussion_r378730830
##########
File path:
CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
##########
@@ -46,7 +46,7 @@ - (void)parser:(NSXMLParser*)parser
didStartElement:(NSString*)elementName names
- (void)parserDidStartDocument:(NSXMLParser*)parser
{
// file: url <allow-navigations> are added by default
- self.allowNavigations = [[NSMutableArray alloc] initWithArray:@[
@"file://" ]];
+ self.allowNavigations = [[NSMutableArray alloc] initWithArray:@[
@"file://", @"app://" ]];
Review comment:
Is this "app://" scheme fixed? (In this case, do we expect that the user
add `allow-navigation` directive in config.xml in order to allow his own
scheme?)
I think it is better to use `[settings cordovaSettingForKey:@"scheme"];`
here instead of fixed "app://", if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
