DavidM42 commented on a change in pull request #769: Add Python 3 compatibility
to bin/cordova_plist_to_config_xml
URL: https://github.com/apache/cordova-ios/pull/769#discussion_r380293330
##########
File path: bin/cordova_plist_to_config_xml
##########
@@ -101,7 +106,7 @@ def UpdateProjectFile(path):
if 'Cordova.plist' in line:
line = line.replace('Cordova.plist', 'config.xml')
line = line.replace('lastKnownFileType = text.plist.xml',
'lastKnownFileType = text.xml')
- print line,
+ print(line, end='')
Review comment:
Why is it important to overwrite the newline character at the end of print
here? Does this need to print in one line? Else `end=''` could be left out
Edit:
Just checked and `end=''` parameter produced a syntax error in my
Python2.7.17 environment. Even if it works it may be safer to remove in terms
of cross compatibility
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
