erisu edited a comment on issue #794: style: remove extra space from 
Objective-C test modules
URL: https://github.com/apache/cordova-ios/pull/794#issuecomment-587981992
 
 
   LGTM.
   
   Sorry I made some changes to the PR entry.
   
   I don't find this as a bug as it does not break tests or built apps in 
anyway. It is more of a styling change and per available tags, `enhancement` 
IMO fits best.
   
   Also for title, though it can be debated, I changed it to `style` since it 
is shorter and fits the type of changes.
   
   I been using recently these as my own personal guide but slightly modified.  
We don't really have a hard requirement on this format and is more a freely to 
use I guess.
   
   https://karma-runner.github.io/1.0/dev/git-commit-msg.html
   https://www.conventionalcommits.org/en/v1.0.0/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to