brodybits opened a new pull request #795: breaking: *-Info.plist config fixes and improvements URL: https://github.com/apache/cordova-ios/pull/795 This is proposed to include and supersede PR #765, as a solution for #764, with some additional fixes and test updates that I think should be included at the same time. - updates and improvements to unit testing of projectFile parse method, now with xcworkspace included in the "ios-config-xml" fixture - include all changes from PR #765 so far, with possible solution to issue #764 - some followup fixes to PR #765 - add test cases for the code updated in PR #765 - some more general improvements This proposal should be considered breaking since it now depends on existence of xcworkspace with the correct name. This should have been present in generated platforms/ios project for years. I have discussed some other related issues with plists in #793, not sure whether or not this proposal would resolve any such related issues. I would like to have multiple reviews before getting this proposal merged. I think it should be good to merge this with a squash merge, with all co-authored-by credits that I gave in 8dfeedc8f754f7638b96b6677a0f34a4d246c8c5, maybe with a rebase to cleanup some of the items that will go into the commit message. closes #765 (PR #765) resolves #764 /cc @leogoesger
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
