wvengen commented on issue #614: [Android] beforeload event for POST method is 
not fired
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/614#issuecomment-591523793
 
 
   As far as I can see in the code, there were preparations to get `POST` 
supported, but it is not yet handled. The change you mention paves the way a 
bit, and makes sure that `POST` doesn't break too much (before it would not 
consider the request method).
   
   >  if beforeload=yes is specified and a POST request is detected as the HTTP 
request method, beforeload behaviour will not be applied
   
   That is visible in [the current 
code](https://github.com/apache/cordova-plugin-inappbrowser/blob/7b42f3e1052ca0e0d225407dcb226562b47f6260/src/android/InAppBrowser.java#L1217).
   
   The README currently mentions:
   
   > Note that POST requests are not currently supported and will be ignored 
(if you set beforeload=post it will raise an error).
   
   This could be improved to read something like:
   
   > Note that POST requests are not currently supported and will be ignored 
(if you set beforeload=post it will raise an error, if you set beforeload=yes 
it will only handle GET requests).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to