erisu commented on a change in pull request #110: Remove traces of UIWebView API
URL:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/110#discussion_r385138749
##########
File path: src/ios/CDVWKWebViewEngine.m
##########
@@ -432,7 +432,7 @@ - (void) webView: (WKWebView *) webView
decidePolicyForNavigationAction: (WKNavi
// https://issues.apache.org/jira/browse/CB-12497
int navType = (int)navigationAction.navigationType;
if (WKNavigationTypeOther == navigationAction.navigationType) {
- navType = (int)UIWebViewNavigationTypeOther;
+ navType = 5; // UIWebViewNavigationTypeOther
}
Review comment:
Also,
* For UIWebView, `UIWebViewNavigationTypeOther` has the value of `5`
* For WKWebView, `WKNavigationTypeOther` has the value of `-1`
This change wouldn't have worked as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
