erisu commented on a change in pull request #543: GH-542 Adding Podspec for
Cordova library
URL: https://github.com/apache/cordova-ios/pull/543#discussion_r389686424
##########
File path: Cordova.podspec
##########
@@ -0,0 +1,37 @@
+require "json"
+
+packageJson = JSON.parse(File.read(File.join(__dir__, "package.json")))
+relVersion = package['version']
+relSource = { :git => "https://github.com/apache/cordova-ios.git";,
+ :tag => "rel/{relVersion}",
+ :submodules => true }
+
+Pod::Spec.new do |s|
+ s.name = "Cordova"
+ s.version = relVersion
+ s.summary = "Apache Cordova for iOS"
+ s.homepage = "https://github.com/apache/cordova-ios";
+ s.license = { :type => "Apache 2.0", :file => "LICENSE" }
+ s.author = { "Apache Software Foundation" }
+ s.platform = :ios, "11.0"
+ s.source = relSource
+ s.requires_arc = true
+ s.preserve_paths = 'CordovaLib/cordova.js', 'CordovaLib/VERSION'
+ s.frameworks = 'AssetsLibrary', 'MobileCoreServices', 'AVFoundation',
'CoreLocation'
+ s.default_subspec = 'Cordova'
+ s.subspec 'Cordova' do |cordova|
+ cordova.source_files = 'CordovaLib/Classes/**/*.{h,m}',
'CordovaLib/Cordova/Cordova.h'
+ cordova.public_header_files = 'CordovaLib/Classes/Public/CDV.h',
'CordovaLib/Classes/Public/CDVAppDelegate.h',
'CordovaLib/Classes/Public/CDVAvailability.h',
'CordovaLib/Classes/Public/CDVAvailabilityDeprecated.h',
'CordovaLib/Classes/Public/CDVCommandDelegate.h',
'CordovaLib/Classes/Public/CDVCommandDelegateImpl.h',
'CordovaLib/Classes/Public/CDVCommandQueue.h',
'CordovaLib/Classes/Public/CDVConfigParser.h',
'CordovaLib/Classes/Public/CDVInvokedUrlCommand.h',
'CordovaLib/Classes/Public/CDVPlugin+Resources.h',
'CordovaLib/Classes/Public/CDVPlugin.h',
'CordovaLib/Classes/Public/CDVPluginResult.h',
'CordovaLib/Classes/Public/CDVScreenOrientationDelegate.h',
'CordovaLib/Classes/Public/CDVTimer.h',
'CordovaLib/Classes/Public/CDVUserAgentUtil.h',
'CordovaLib/Classes/Public/CDVViewController.h',
'CordovaLib/Classes/Public/CDVWebViewEngineProtocol.h',
'CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewUIDelegate.h',
'CordovaLib/Classes/Public/CDVWhitelist.h', 'CordovaLib/Cordova/Cordova.h',
'CordovaLib/Classes/Public/NSDictionary+CordovaPreferences.h',
'CordovaLib/Classes/Public/NSMutableArray+QueueAdditions.h'
Review comment:
Can the `public_header_files` property also be written in the same pattern
like `source_files`?
```
cordova.public_header_files = 'CordovaLib/Classes/Public/**/*.{h}',
'CordovaLib/Cordova/Cordova.h'
```
I just noticed that this list is manually maintained and that the list is
now not matching what is in master.
* `CDVUserAgentUtil.h` had been removed
* `CDVURLSchemeHandler.h` has been added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
