breautek commented on issue #808: (iOS) Dark mode splashscreen storyboard images URL: https://github.com/apache/cordova-ios/pull/808#issuecomment-597158598 Thank you for your PR. Just a couple notes, not exactly related to this PR, but when making PRs in general. > I haven't run any tests You can run local tests on your machine by running `npm test`. This will help catch some problems (such as your eslint error :stuck_out_tongue_winking_eye: ) I also noticed that you made changes in your fork's master branch for your PR. I would recommend always creating a new branch for your PRs to keep your master branch clean. This isn't a problem right now, but could be later. If you add more commits to your master (maybe for a different PR) those commits will end up in this PR as well and that would not be very desirable. Regarding this PR specifically, I think everything looks good and I'm happy you considered making specifying the appearance optional, which also helps maintain backwards compatibility. As soon as the checks turn green I'll give my :+1:
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
