breautek commented on issue #924: Crash Report: ConcurrentModificationException URL: https://github.com/apache/cordova-android/issues/924#issuecomment-613745852 @HansKrywaa I have a branch at https://github.com/breautek/cordova-android/commits/concurrent-plugin-manager-8.1 I would advise you to fork `cordova-android` and merge my branch into your own fork (that way you have complete control) Then you can install the platform via `cordova platform add https://github./com/yourgitrepo.git#your-branch` Just like any `cordova-android` update, you'll need to remove the platform first by doing: `cordova platform remove android` You can look at the change set at https://github.com/breautek/cordova-android/commit/bfda452a09ba26412e0f527f6af1957379d89453 Upon further reading, it looks like I didn't need to wrap everything inside a `synchronized` block, **unless** if you use the iterators, which the codebase does not. So using `Collections.synchronizedMap` should be enough, but again, hard to say for certain when we lack a reproducible test case. I saw no significant performance impact with my test app, but obviously my test app wasn't a real production app. It was just the cordova hello world app with all of the apache plugins installed. I'll leave it up to you if you see any significant performance impacts on your app, which would represent a real-world scenario. Given how frequent the crash appears to occur... with any luck, you won't see the crash for the next 30 days or so...? :crossed_fingers: Please do keep me updated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
