erisu commented on a change in pull request #54: URL: https://github.com/apache/cordova-plugin-device-orientation/pull/54#discussion_r476364435
########## File path: README.md ########## @@ -27,15 +27,200 @@ description: Access compass data. # cordova-plugin-device-orientation +# Usage Notice + +With the [W3C Device Orientation API](https://www.w3.org/TR/orientation-event/) now being supported on Android, iOS and Windows devices, this plugin may not needed any more. Review comment: ```suggestion With the [W3C Device Orientation API](https://www.w3.org/TR/orientation-event/), Android, iOS, and Windows devices may not need this plugin anymore. ``` ########## File path: README.md ########## @@ -27,15 +27,200 @@ description: Access compass data. # cordova-plugin-device-orientation +# Usage Notice + +With the [W3C Device Orientation API](https://www.w3.org/TR/orientation-event/) now being supported on Android, iOS and Windows devices, this plugin may not needed any more. + +However, for iOS 13+ a so called [secure context](https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts) is required. Apple does not allow access to the device’s orientation or the permission request from insecure browsing contexts. If you use a custom scheme, i.e., do not use the `file` protocol for your iOS app the browsing context is considered insecure. To solve this problem, the plugin is mandatory for iOS 13+ if you plan to use the device orientation feature. Review comment: ```suggestion However, for iOS 13+, a [secure context](https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts) is required. Apple does not allow access to the device’s orientation or the permission request from an insecure browsing context. If you use a custom scheme, i.e., the `app` protocol, for your iOS app, the browsing context is considered insecure. To solve this problem and be able to use the device orientation feature, this plugin will be necessary on iOS 13+. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
