This is an automated email from the ASF dual-hosted git repository.

jcesarmobile pushed a commit to branch file-cookies
in repository https://gitbox.apache.org/repos/asf/cordova-android.git

commit 3af246e4ae40b7ec38df8555565efab239abdf8e
Author: jcesarmobile <[email protected]>
AuthorDate: Wed Jun 29 00:50:13 2022 +0200

    fix: accept file cookies only if AndroidInsecureFileModeEnabled
---
 framework/src/org/apache/cordova/engine/SystemCookieManager.java | 8 +++++---
 framework/src/org/apache/cordova/engine/SystemWebViewEngine.java | 1 +
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/framework/src/org/apache/cordova/engine/SystemCookieManager.java 
b/framework/src/org/apache/cordova/engine/SystemCookieManager.java
index df8cbac3..bc980356 100644
--- a/framework/src/org/apache/cordova/engine/SystemCookieManager.java
+++ b/framework/src/org/apache/cordova/engine/SystemCookieManager.java
@@ -19,8 +19,6 @@
 
 package org.apache.cordova.engine;
 
-import android.annotation.TargetApi;
-import android.os.Build;
 import android.webkit.CookieManager;
 import android.webkit.WebView;
 
@@ -35,10 +33,14 @@ class SystemCookieManager implements ICordovaCookieManager {
         webView = webview;
         cookieManager = CookieManager.getInstance();
 
-        cookieManager.setAcceptFileSchemeCookies(true);
         cookieManager.setAcceptThirdPartyCookies(webView, true);
     }
 
+    @SuppressWarnings("deprecation")
+    public void setAcceptFileSchemeCookies() {
+        cookieManager.setAcceptFileSchemeCookies(true);
+    }
+
     public void setCookiesEnabled(boolean accept) {
         cookieManager.setAcceptCookie(accept);
     }
diff --git a/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java 
b/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
index 71fa33dd..5ff1abff 100755
--- a/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
+++ b/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
@@ -165,6 +165,7 @@ public class SystemWebViewEngine implements 
CordovaWebViewEngine {
             LOG.d(TAG, "Enabled insecure file access");
             settings.setAllowFileAccess(true);
             settings.setAllowUniversalAccessFromFileURLs(true);
+            cookieManager.setAcceptFileSchemeCookies();
         }
 
         settings.setMediaPlaybackRequiresUserGesture(false);


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to