This is an automated email from the ASF dual-hosted git repository.

dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git


The following commit(s) were added to refs/heads/master by this push:
     new 700c32b8 chore: Remove unused BackupWebStorage preference (#1339)
700c32b8 is described below

commit 700c32b8d164363108d9af00c07e9a0fc72eba5d
Author: Darryl Pogue <[email protected]>
AuthorDate: Tue Jun 6 22:59:27 2023 -0700

    chore: Remove unused BackupWebStorage preference (#1339)
    
    Fixes #1332.
---
 CordovaLib/Classes/Public/CDVViewController.m                | 8 --------
 templates/cordova/defaults.xml                               | 1 -
 templates/project/__PROJECT_NAME__/config.xml                | 1 -
 tests/CordovaLibTests/CordovaLibApp/config.xml               | 1 -
 tests/spec/unit/fixtures/ios-config-xml/SampleApp/config.xml | 1 -
 tests/spec/unit/fixtures/ios-config-xml/cordova/defaults.xml | 1 -
 6 files changed, 13 deletions(-)

diff --git a/CordovaLib/Classes/Public/CDVViewController.m 
b/CordovaLib/Classes/Public/CDVViewController.m
index e47519b8..3b95fc98 100644
--- a/CordovaLib/Classes/Public/CDVViewController.m
+++ b/CordovaLib/Classes/Public/CDVViewController.m
@@ -278,14 +278,6 @@
     // Load settings
     [self loadSettings];
 
-    NSString* backupWebStorageType = @"cloud"; // default value
-
-    id backupWebStorage = [self.settings 
cordovaSettingForKey:@"BackupWebStorage"];
-    if ([backupWebStorage isKindOfClass:[NSString class]]) {
-        backupWebStorageType = backupWebStorage;
-    }
-    [self.settings setCordovaSetting:backupWebStorageType 
forKey:@"BackupWebStorage"];
-
     // // Instantiate the Launch screen /////////
 
     if (!self.launchView) {
diff --git a/templates/cordova/defaults.xml b/templates/cordova/defaults.xml
index ebbe6f66..1a7287d2 100644
--- a/templates/cordova/defaults.xml
+++ b/templates/cordova/defaults.xml
@@ -23,7 +23,6 @@
 
     <!-- Preferences for iOS -->
     <preference name="AllowInlineMediaPlayback" value="false" />
-    <preference name="BackupWebStorage" value="cloud" />
     <preference name="DisallowOverscroll" value="false" />
     <preference name="EnableViewportScale" value="false" />
     <preference name="MediaTypesRequiringUserActionForPlayback" value="none" />
diff --git a/templates/project/__PROJECT_NAME__/config.xml 
b/templates/project/__PROJECT_NAME__/config.xml
index fed22f1a..5633d805 100644
--- a/templates/project/__PROJECT_NAME__/config.xml
+++ b/templates/project/__PROJECT_NAME__/config.xml
@@ -49,7 +49,6 @@
 
     <!-- Preferences for iOS -->
     <preference name="AllowInlineMediaPlayback" value="false" />
-    <preference name="BackupWebStorage" value="cloud" />
     <preference name="DisallowOverscroll" value="false" />
     <preference name="EnableViewportScale" value="false" />
     <preference name="MediaTypesRequiringUserActionForPlayback" value="false" 
/>
diff --git a/tests/CordovaLibTests/CordovaLibApp/config.xml 
b/tests/CordovaLibTests/CordovaLibApp/config.xml
index 2528c1cb..8edd59ca 100644
--- a/tests/CordovaLibTests/CordovaLibApp/config.xml
+++ b/tests/CordovaLibTests/CordovaLibApp/config.xml
@@ -37,7 +37,6 @@
 
     <!-- Preferences for iOS -->
     <preference name="AllowInlineMediaPlayback" value="false" />
-    <preference name="BackupWebStorage" value="cloud" />
     <preference name="DisallowOverscroll" value="false" />
     <preference name="EnableViewportScale" value="false" />
     <preference name="MediaTypesRequiringUserActionForPlayback" value="false" 
/>
diff --git a/tests/spec/unit/fixtures/ios-config-xml/SampleApp/config.xml 
b/tests/spec/unit/fixtures/ios-config-xml/SampleApp/config.xml
index bfadd563..e7970de3 100755
--- a/tests/spec/unit/fixtures/ios-config-xml/SampleApp/config.xml
+++ b/tests/spec/unit/fixtures/ios-config-xml/SampleApp/config.xml
@@ -33,7 +33,6 @@
     <allow-intent href="itms:*" />
     <allow-intent href="itms-apps:*" />
     <preference name="AllowInlineMediaPlayback" value="false" />
-    <preference name="BackupWebStorage" value="cloud" />
     <preference name="DisallowOverscroll" value="false" />
     <preference name="EnableViewportScale" value="false" />
     <preference name="MediaTypesRequiringUserActionForPlayback" value="false" 
/>
diff --git a/tests/spec/unit/fixtures/ios-config-xml/cordova/defaults.xml 
b/tests/spec/unit/fixtures/ios-config-xml/cordova/defaults.xml
index 2dd257fc..370004f2 100644
--- a/tests/spec/unit/fixtures/ios-config-xml/cordova/defaults.xml
+++ b/tests/spec/unit/fixtures/ios-config-xml/cordova/defaults.xml
@@ -23,7 +23,6 @@
 
     <!-- Preferences for iOS -->
     <preference name="AllowInlineMediaPlayback" value="false" />
-    <preference name="BackupWebStorage" value="cloud" />
     <preference name="DisallowOverscroll" value="false" />
     <preference name="EnableViewportScale" value="false" />
     <preference name="MediaTypesRequiringUserActionForPlayback" value="none" />


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to