[cordova-plugin-file] branch master updated: fix(android): hasWritePermission for SDK 33 (#608)

[erisu]

This is an automated email from the ASF dual-hosted git repository.

erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-file.git


The following commit(s) were added to refs/heads/master by this push:
     new c10942a  fix(android): hasWritePermission for SDK 33 (#608)
c10942a is described below

commit c10942a0c25a70d4da87db1c4faa189669a10566
Author: エリス <er...@users.noreply.github.com>
AuthorDate: Wed Oct 18 08:32:06 2023 +0900

    fix(android): hasWritePermission for SDK 33 (#608)
    
    Co-authored-by: EYALIN <yalin.el...@gmail.com>
---
 src/android/FileUtils.java | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/android/FileUtils.java b/src/android/FileUtils.java
index d12aa52..0edf90a 100644
--- a/src/android/FileUtils.java
+++ b/src/android/FileUtils.java
@@ -543,8 +543,10 @@ public class FileUtils extends CordovaPlugin {
     }
 
     private void getWritePermission(String rawArgs, int action, 
CallbackContext callbackContext) {
-        int requestCode = pendingRequests.createRequest(rawArgs, action, 
callbackContext);
-        PermissionHelper.requestPermission(this, requestCode, 
Manifest.permission.WRITE_EXTERNAL_STORAGE);
+        if (android.os.Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU) {
+            int requestCode = pendingRequests.createRequest(rawArgs, action, 
callbackContext);
+            PermissionHelper.requestPermission(this, requestCode, 
Manifest.permission.WRITE_EXTERNAL_STORAGE);
+        }
     }
 
     /**
@@ -567,7 +569,10 @@ public class FileUtils extends CordovaPlugin {
     }
 
     private boolean hasWritePermission() {
-        return PermissionHelper.hasPermission(this, 
Manifest.permission.WRITE_EXTERNAL_STORAGE);
+        // Starting with API 33, requesting WRITE_EXTERNAL_STORAGE is an auto 
permission rejection
+        return android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU
+                ? true
+                : PermissionHelper.hasPermission(this, 
Manifest.permission.WRITE_EXTERNAL_STORAGE);
     }
 
     private boolean needPermission(String nativeURL, int permissionType) 
throws JSONException {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org