Repository: couchdb-setup Updated Branches: refs/heads/fix/node-count [created] 786f45ed2
fix: make sure cluster setups do not exceed n=3 by default Single node setups want an n=1 setting, but that is the only time the number of nodes and the number of replicas is linked. In larger clusters, the values should not be the same. This patch ensures that for clusters >3 nodes, we do not have to tell the users to set node_count to 3 in the _cluster_setup API. More context for this in https://issues.apache.org/jira/browse/COUCHDB-2594 Project: http://git-wip-us.apache.org/repos/asf/couchdb-setup/repo Commit: http://git-wip-us.apache.org/repos/asf/couchdb-setup/commit/786f45ed Tree: http://git-wip-us.apache.org/repos/asf/couchdb-setup/tree/786f45ed Diff: http://git-wip-us.apache.org/repos/asf/couchdb-setup/diff/786f45ed Branch: refs/heads/fix/node-count Commit: 786f45ed24c949b957209ca1427faa1461d5d65d Parents: 4d9bd58 Author: Jan Lehnardt <[email protected]> Authored: Sun Jul 30 10:07:46 2017 +0200 Committer: Jan Lehnardt <[email protected]> Committed: Sun Jul 30 10:08:06 2017 +0200 ---------------------------------------------------------------------- src/setup.erl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/couchdb-setup/blob/786f45ed/src/setup.erl ---------------------------------------------------------------------- diff --git a/src/setup.erl b/src/setup.erl index d0ecd2c..c60b9da 100644 --- a/src/setup.erl +++ b/src/setup.erl @@ -169,7 +169,9 @@ setup_node(NewCredentials, NewBindAddress, NodeCount, Port) -> config:set("chttpd", "bind_address", binary_to_list(NewBindAddress)) end, - config:set_integer("cluster", "n", NodeCount), + % for single node setups, set n=1, for larger setups, donât + % exceed n=3 as a default + config:set_integer("cluster", "n", min(NodeCount, 3), case Port of undefined ->
