This is an automated email from the ASF dual-hosted git repository.

willholley pushed a commit to branch remsh
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit dba2df164d311524d216809d2caffb089bed7ecd
Author: Will Holley <[email protected]>
AuthorDate: Wed Dec 11 12:43:41 2019 +0000

    Ignore `ERL_FLAGS` in remsh
    
    If an environment uses `ERL_FLAGS` to configure CouchDB it can
    conflict with the parameters passed to `erl` in `remsh`. This was
    observed in a containerized CouchDB cluster, as the CouchDB
    Dockerfile uses `ERL_FLAGS` to set the node name and cookie, as does
    the Helm chart. When running `remsh` in these containers, additional
    `-name` and `-setcookie` parameters were silently added to
    the `erl` invocation, preventing the shell from connecting to the
    CouchDB node.
---
 rel/overlay/bin/remsh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/rel/overlay/bin/remsh b/rel/overlay/bin/remsh
index 963c16a..a02fd5d 100755
--- a/rel/overlay/bin/remsh
+++ b/rel/overlay/bin/remsh
@@ -71,6 +71,7 @@ if [ ! -z "$VERBOSE" ]; then
   set -x
 fi
 
-exec "$BINDIR/erl" -boot "$ROOTDIR/releases/$APP_VSN/start_clean" \
+# clear ERL_FLAGS to avoid conflicts with the cli parameters
+exec env ERL_FLAGS="" "$BINDIR/erl" -boot 
"$ROOTDIR/releases/$APP_VSN/start_clean" \
     -name remsh$$@$LHOST -remsh $NODE -hidden -setcookie $COOKIE \
     "$@"

Reply via email to