This is an automated email from the ASF dual-hosted git repository. vatamane pushed a commit to branch reduce-smoosh-compaction-log-level-to-debug in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit 7edcc7a111c1de1d5d8ee13f1a8d11200cf08429 Author: Nick Vatamaniuc <[email protected]> AuthorDate: Wed May 11 17:07:21 2022 -0400 Reduce smoosh compaction log level to debug With a few channels around these add up and make local developement not as ergonomic. Let's turn them to `debug` and users can always toggle them to info or error if needed. --- rel/overlay/etc/default.ini | 2 +- src/smoosh/src/smoosh_priority_queue.erl | 4 ++-- src/smoosh/src/smoosh_server.erl | 4 ++-- src/smoosh/src/smoosh_utils.erl | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/rel/overlay/etc/default.ini b/rel/overlay/etc/default.ini index 5fb45b5b5..2ea16cbaa 100644 --- a/rel/overlay/etc/default.ini +++ b/rel/overlay/etc/default.ini @@ -651,7 +651,7 @@ partitioned||* = true state_dir = {{state_dir}} ; Sets the log level for informational compaction related entries. -;compaction_log_level = notice +;compaction_log_level = debug [ioq] ; The maximum number of concurrent in-flight IO requests that diff --git a/src/smoosh/src/smoosh_priority_queue.erl b/src/smoosh/src/smoosh_priority_queue.erl index 000297adf..30dcf4d20 100644 --- a/src/smoosh/src/smoosh_priority_queue.erl +++ b/src/smoosh/src/smoosh_priority_queue.erl @@ -144,7 +144,7 @@ do_recover(FilePath) -> <<Vsn, Binary/binary>> = Content, try parse_queue(Vsn, ?VSN, Binary) of Bin -> - Level = smoosh_utils:log_level("compaction_log_level", "notice"), + Level = smoosh_utils:log_level("compaction_log_level", "debug"), couch_log:Level( "~p Successfully restored state file ~s", [?MODULE, FilePath] ), @@ -158,7 +158,7 @@ do_recover(FilePath) -> error end; {error, enoent} -> - Level = smoosh_utils:log_level("compaction_log_level", "notice"), + Level = smoosh_utils:log_level("compaction_log_level", "debug"), couch_log:Level( "~p (~p) Queue file ~s does not exist. Not restoring.", [?MODULE, enoent, FilePath] ), diff --git a/src/smoosh/src/smoosh_server.erl b/src/smoosh/src/smoosh_server.erl index f0260e91d..145f8d1ab 100644 --- a/src/smoosh/src/smoosh_server.erl +++ b/src/smoosh/src/smoosh_server.erl @@ -173,7 +173,7 @@ handle_call({enqueue, Object}, _From, State) -> handle_call(suspend, _From, State) -> ets:foldl( fun(#channel{name = Name, pid = P}, _) -> - Level = smoosh_utils:log_level("compaction_log_level", "notice"), + Level = smoosh_utils:log_level("compaction_log_level", "debug"), couch_log:Level("Suspending ~p", [Name]), smoosh_channel:suspend(P) end, @@ -184,7 +184,7 @@ handle_call(suspend, _From, State) -> handle_call(resume, _From, State) -> ets:foldl( fun(#channel{name = Name, pid = P}, _) -> - Level = smoosh_utils:log_level("compaction_log_level", "notice"), + Level = smoosh_utils:log_level("compaction_log_level", "debug"), couch_log:Level("Resuming ~p", [Name]), smoosh_channel:resume(P) end, diff --git a/src/smoosh/src/smoosh_utils.erl b/src/smoosh/src/smoosh_utils.erl index 72be58598..ac9b0568f 100644 --- a/src/smoosh/src/smoosh_utils.erl +++ b/src/smoosh/src/smoosh_utils.erl @@ -88,7 +88,7 @@ throw_on_error(Args, {error, Reason}) -> throw({error, {Reason, Args}}). write_to_file(Content, FileName, VSN) -> - Level = log_level("compaction_log_level", "notice"), + Level = log_level("compaction_log_level", "debug"), couch_log:Level("~p Writing state ~s", [?MODULE, FileName]), OnDisk = <<VSN, (erlang:term_to_binary(Content, [compressed, {minor_version, 1}]))/binary>>, TmpFileName = FileName ++ ".tmp",
