This is an automated email from the ASF dual-hosted git repository.

jan pushed a commit to branch rebase/access-2023
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 5f89aa548054ef52a44bb05ed7e36b04e48f2658
Author: Jan Lehnardt <[email protected]>
AuthorDate: Sat Aug 6 12:54:23 2022 +0200

    chore(access): remove old comment
---
 src/couch/src/couch_db_updater.erl | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/couch/src/couch_db_updater.erl 
b/src/couch/src/couch_db_updater.erl
index 01ab09b1b..6d6a33f57 100644
--- a/src/couch/src/couch_db_updater.erl
+++ b/src/couch/src/couch_db_updater.erl
@@ -796,11 +796,6 @@ update_docs_int(Db, DocsList, LocalDocs, 
ReplicatedChanges, UserCtx) ->
 % at this point, we already validated this Db is access enabled, so do the 
checks right away.
 check_access(Db, UserCtx, Access) -> 
couch_db:check_access(Db#db{user_ctx=UserCtx}, Access).
 
-% TODO: looks like we go into validation here unconditionally and only check in
-%       check_access() whether the Db has_access_enabled(), we should do this
-%       here on the outside. Might be our perf issue.
-%       However, if it is, that means we have to speed this up as it would 
still
-%       be too slow for when access is enabled.
 validate_docs_access(Db, UserCtx, DocsList, OldDocInfos) ->
     case couch_db:has_access_enabled(Db) of
         true -> validate_docs_access_int(Db, UserCtx, DocsList, OldDocInfos);

Reply via email to