[couchdb] branch main updated: Fix a few couch_os_process metrics

[vatamane]

This is an automated email from the ASF dual-hosted git repository.

vatamane pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/couchdb.git


The following commit(s) were added to refs/heads/main by this push:
     new da6fb7920 Fix a few couch_os_process metrics
da6fb7920 is described below

commit da6fb79202057ede81eecd2a6fe3d5b6637d2c1d
Author: Nick Vatamaniuc <vatam...@gmail.com>
AuthorDate: Mon Oct 16 11:29:33 2023 -0400

    Fix a few couch_os_process metrics
    
    Some were misnamed:
      * exists -> exits
      * process_prompt_errors is just errors
      * description of process_errors was incorrect
    
    Some were missing:
      * process_error_exits was not defined in the cfg file
---
 src/couch/priv/stats_descriptions.cfg   | 14 +++++++-------
 src/couch/test/eunit/couch_js_tests.erl |  3 ++-
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/src/couch/priv/stats_descriptions.cfg 
b/src/couch/priv/stats_descriptions.cfg
index 2d40518e2..af66ba06e 100644
--- a/src/couch/priv/stats_descriptions.cfg
+++ b/src/couch/priv/stats_descriptions.cfg
@@ -314,22 +314,22 @@
     {type, counter},
     {desc, <<"number of OS process starts">>}
 ]}.
-{[couchdb, query_server, process_exists], [
+{[couchdb, query_server, process_exits], [
     {type, counter},
-    {desc, <<"number of OS normal process exits">>}
+    {desc, <<"number of normal OS process exits">>}
+]}.
+{[couchdb, query_server, process_error_exits], [
+    {type, counter},
+    {desc, <<"number of error OS process exits">>}
 ]}.
 {[couchdb, query_server, process_errors], [
     {type, counter},
-    {desc, <<"number of OS error process exits">>}
+    {desc, <<"number of OS process errors">>}
 ]}.
 {[couchdb, query_server, process_prompts], [
     {type, counter},
     {desc, <<"number of successful OS process prompts">>}
 ]}.
-{[couchdb, query_server, process_prompt_errors], [
-    {type, counter},
-    {desc, <<"number of OS process prompt errors">>}
-]}.
 {[couchdb, query_server, time, spawn_proc], [
     {type, counter},
     {desc, <<"accumulated number of microseconds spent spawning os query 
processes">>}
diff --git a/src/couch/test/eunit/couch_js_tests.erl 
b/src/couch/test/eunit/couch_js_tests.erl
index 9bade6b9c..059a07e20 100644
--- a/src/couch/test/eunit/couch_js_tests.erl
+++ b/src/couch/test/eunit/couch_js_tests.erl
@@ -57,8 +57,9 @@ should_create_sandbox(_) ->
     ?assert(couch_stats:sample([couchdb, query_server, process_starts]) > 0),
     ?assert(couch_stats:sample([couchdb, query_server, process_prompts]) > 0),
     ?assert(couch_stats:sample([couchdb, query_server, acquired_processes]) > 
0),
-    ?assert(couch_stats:sample([couchdb, query_server, process_exists]) >= 0),
+    ?assert(couch_stats:sample([couchdb, query_server, process_exits]) >= 0),
     ?assert(couch_stats:sample([couchdb, query_server, process_errors]) >= 0),
+    ?assert(couch_stats:sample([couchdb, query_server, process_error_exits]) 
>= 0),
     couch_query_servers:ret_os_process(Proc).
 
 %% erlfmt-ignore