This is an automated email from the ASF dual-hosted git repository. jiahuili430 pushed a commit to branch improve-couch-debug in repository https://gitbox.apache.org/repos/asf/couchdb.git
commit 2ba06b06eaf3b5d5b2f669f08ccd2d2de6937b66 Author: Jiahui Li <[email protected]> AuthorDate: Wed May 14 16:45:11 2025 -0500 Fix `couch_debug:ping/1` function clause error Error log: ``` ** exception error: no function clause matching mem3:ping_nodes(['[email protected]']) (src/mem3.erl, line 453) ``` --- src/couch/src/couch_debug.erl | 5 +++-- src/mem3/src/mem3.erl | 5 ++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/couch/src/couch_debug.erl b/src/couch/src/couch_debug.erl index 0e89bfaf0..0a8ed70ba 100644 --- a/src/couch/src/couch_debug.erl +++ b/src/couch/src/couch_debug.erl @@ -451,6 +451,7 @@ help(ping) -> help(ping_nodes) -> io:format(" ping_nodes() + ping_nodes(Nodes) ping_nodes(Timeout) ping_nodes(Nodes, Timeout) -------------------------------- @@ -959,8 +960,8 @@ ping(Node, Timeout) -> ping_nodes() -> mem3:ping_nodes(). -ping_nodes(Timeout) -> - mem3:ping_nodes(Timeout). +ping_nodes(NodesOrTimeout) -> + mem3:ping_nodes(NodesOrTimeout). ping_nodes(Nodes, Timeout) -> mem3:ping_nodes(Nodes, Timeout). diff --git a/src/mem3/src/mem3.erl b/src/mem3/src/mem3.erl index c0d64d7e4..463842ef2 100644 --- a/src/mem3/src/mem3.erl +++ b/src/mem3/src/mem3.erl @@ -448,8 +448,11 @@ ping(Node, Timeout) when is_atom(Node) -> ping_nodes() -> ping_nodes(live_cluster_nodes(), ?PING_TIMEOUT_IN_MS). --spec ping_nodes(Timeout :: pos_integer()) -> [{node(), pos_integer() | Error :: term()}]. +-spec ping_nodes(Nodes :: [node()] | Timeout :: pos_integer()) -> + [{node(), pos_integer() | Error :: term()}]. +ping_nodes(Nodes) when is_list(Nodes) -> + ping_nodes(Nodes, ?PING_TIMEOUT_IN_MS); ping_nodes(Timeout) when is_integer(Timeout), Timeout > 0 -> ping_nodes(live_cluster_nodes(), Timeout).
