NvmfStagingBufferCache: enhance excpetion message Add values of illegal arguments to exception message to make it easier for the user to debug.
Signed-off-by: Jonas Pfefferle <peppe...@apache.org> Project: http://git-wip-us.apache.org/repos/asf/incubator-crail/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-crail/commit/176bc39c Tree: http://git-wip-us.apache.org/repos/asf/incubator-crail/tree/176bc39c Diff: http://git-wip-us.apache.org/repos/asf/incubator-crail/diff/176bc39c Branch: refs/heads/master Commit: 176bc39cf59a30b85e69512c89fc7c5004e137a8 Parents: 34e0af4 Author: Jonas Pfefferle <peppe...@apache.org> Authored: Tue Apr 10 11:00:06 2018 +0200 Committer: Jonas Pfefferle <peppe...@apache.org> Committed: Tue Apr 10 13:19:03 2018 +0200 ---------------------------------------------------------------------- .../crail/storage/nvmf/client/NvmfStagingBufferCache.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-crail/blob/176bc39c/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStagingBufferCache.java ---------------------------------------------------------------------- diff --git a/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStagingBufferCache.java b/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStagingBufferCache.java index dcfc411..fdc0a69 100644 --- a/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStagingBufferCache.java +++ b/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStagingBufferCache.java @@ -43,10 +43,10 @@ public class NvmfStagingBufferCache { NvmfStagingBufferCache(CrailBufferCache bufferCache, int maxEntries, int lbaDataSize) { if (maxEntries <= 0) { - throw new IllegalArgumentException("maximum entries <= 0"); + throw new IllegalArgumentException("maximum entries (" + maxEntries + ") <= 0"); } if (lbaDataSize <= 0) { - throw new IllegalArgumentException("LBA data size <= 0"); + throw new IllegalArgumentException("LBA data size (" + lbaDataSize + ") <= 0"); } this.remoteAddressMap = new ConcurrentHashMap<>(maxEntries); this.freeBuffers = new ArrayBlockingQueue<>(maxEntries); @@ -78,7 +78,8 @@ public class NvmfStagingBufferCache { throw new OutOfMemoryError(); } if (buffer.capacity() < lbaDataSize) { - throw new IllegalArgumentException("Slice size smaller LBA data size"); + throw new IllegalArgumentException("Slice size (" + buffer.capacity() + ") smaller LBA data size (" + + lbaDataSize + ")"); } int numStagingBuffers = buffer.remaining() / lbaDataSize; while (numStagingBuffers-- > 0 && buffersLeft > 0) {
