[incubator-crail] branch master updated: [NVMf] do not append port to subsystem NQN Appending the port to the subsystem NQN was introduced to allow connecting to multiple targets on the same host. This problem occured because we currently do not store subsystem NQN information at the namenode, so there is only one global subsystem NQN in the configuration file. For now we are removing this hack because it confuses users.

[pepperjo]

This is an automated email from the ASF dual-hosted git repository.

pepperjo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-crail.git


The following commit(s) were added to refs/heads/master by this push:
     new 2c74880  [NVMf] do not append port to subsystem NQN Appending the port 
to the subsystem NQN was introduced to allow connecting to multiple targets on 
the same host. This problem occured because we currently do not store subsystem 
NQN information at the namenode, so there is only one global subsystem NQN in 
the configuration file. For now we are removing this hack because it confuses 
users.
     new e9f4eb1  Merge pull request #70 from PepperJo/nqn_port_fix
2c74880 is described below

commit 2c74880ce401a6851250c4b5de69c8425ba8ea2e
Author: Jonas Pfefferle <peppe...@apache.org>
AuthorDate: Thu Mar 7 10:09:12 2019 +0100

    [NVMf] do not append port to subsystem NQN
    Appending the port to the subsystem NQN was introduced to allow
    connecting to multiple targets on the same host. This problem occured
    because we currently do not store subsystem NQN information at the
    namenode, so there is only one global subsystem NQN in the configuration
    file. For now we are removing this hack because it confuses users.
    
    https://issues.apache.org/jira/browse/CRAIL-95
    
    Signed-off-by: Jonas Pfefferle <peppe...@apache.org>
---
 .../java/org/apache/crail/storage/nvmf/client/NvmfStorageEndpoint.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStorageEndpoint.java
 
b/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStorageEndpoint.java
index 5c0084e..4ae7ae8 100644
--- 
a/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStorageEndpoint.java
+++ 
b/storage-nvmf/src/main/java/org/apache/crail/storage/nvmf/client/NvmfStorageEndpoint.java
@@ -62,7 +62,7 @@ public class NvmfStorageEndpoint implements StorageEndpoint {
                                InetAddress.getByAddress(info.getIpAddress()), 
info.getPort());
                // XXX FIXME: nsid from datanodeinfo
                NvmfTransportId transportId = new 
NvmfTransportId(inetSocketAddress,
-                               new 
NvmeQualifiedName(NvmfStorageConstants.NQN.toString() + info.getPort()));
+                               new 
NvmeQualifiedName(NvmfStorageConstants.NQN.toString()));
                LOG.info("Connecting to NVMf target at " + 
transportId.toString());
                controller = nvme.connect(transportId);
                controller.getControllerConfiguration().setEnable(true);