:While looking at this change, I found an odd piece of code in pf_route6()
:at line 5384; there's no prior call to crit_exit() in this function.
:Is this OK?
:
:       /* Cheat. XXX why only in the v6 case??? */
:       if (r->rt == PF_FASTROUTE) {
:               m0->m_pkthdr.pf.flags |= PF_TAG_GENERATED;
:               ip6_output(m0, NULL, NULL, 0, NULL, NULL, NULL);
:               crit_enter();
:               return;
:       }

    No, that looks totaly broken.  I'll remove the bogus enter.
    Nice catch.

                                        -Matt
                                        Matthew Dillon 
                                        <[email protected]>

Reply via email to