Author: rdonkin
Date: Sun Dec  8 19:09:40 2013
New Revision: 1549123

URL: http://svn.apache.org/r1549123
Log:
Apply PMD Rules.

Modified:
    
creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/ArchiveGuesser.java

Modified: 
creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/ArchiveGuesser.java
URL: 
http://svn.apache.org/viewvc/creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/ArchiveGuesser.java?rev=1549123&r1=1549122&r2=1549123&view=diff
==============================================================================
--- 
creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/ArchiveGuesser.java
 (original)
+++ 
creadur/rat/branches/gsoc/apache-rat-core/src/main/java/org/apache/rat/document/impl/guesser/ArchiveGuesser.java
 Sun Dec  8 19:09:40 2013
@@ -47,9 +47,9 @@ public class ArchiveGuesser {
         * @param archiveExtensions
         *            the archive extensions
         */
-       public ArchiveGuesser(final String[] archiveExtensions) {
+       public ArchiveGuesser(final String... archiveExtensions) {
                super();
-               this.archiveExtensions = archiveExtensions;
+               this.archiveExtensions = archiveExtensions.clone();
        }
 
        /**
@@ -71,15 +71,16 @@ public class ArchiveGuesser {
         * @return true, if is archive
         */
        public boolean isArchive(final String name) {
-               if (name == null) {
-                       return false;
-               }
-               final String nameToLower = name.toLowerCase(Locale.US);
-               for (final String element : this.archiveExtensions) {
-                       if (nameToLower.endsWith("." + element)) {
-                               return true;
+               boolean result = false;
+               if (name != null) {
+                       final String nameToLower = name.toLowerCase(Locale.US);
+                       for (String element : this.archiveExtensions) {
+                               if (nameToLower.endsWith("." + element)) {
+                                       result = true;
+                                       break;
+                               }
                        }
                }
-               return false;
+               return result;
        }
 }


Reply via email to