Author: sebb
Date: Tue Aug 12 01:08:49 2014
New Revision: 1617389
URL: http://svn.apache.org/r1617389
Log:
Use in-line comments for @SuppressWarnings
This means a grep can be used to easily find any which have not been justified
with a comment
Modified:
creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/analysis/license/DirectoryScanner.java
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java
Modified:
creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/analysis/license/DirectoryScanner.java
URL:
http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/analysis/license/DirectoryScanner.java?rev=1617389&r1=1617388&r2=1617389&view=diff
==============================================================================
---
creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/analysis/license/DirectoryScanner.java
(original)
+++
creadur/rat/trunk/apache-rat-core/src/test/java/org/apache/rat/analysis/license/DirectoryScanner.java
Tue Aug 12 01:08:49 2014
@@ -32,7 +32,7 @@ import org.junit.Assert;
class DirectoryScanner {
- @SuppressWarnings("boxing")
+ @SuppressWarnings("boxing") // OK in test code
/**
* Get list of files in a directory, and scan for license matches
* @param directory the directory containing the files
Modified:
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java
URL:
http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java?rev=1617389&r1=1617388&r2=1617389&view=diff
==============================================================================
---
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java
(original)
+++
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/AbstractRatMojo.java
Tue Aug 12 01:08:49 2014
@@ -245,8 +245,7 @@ public abstract class AbstractRatMojo ex
try {
final ClassLoader cl = Thread.currentThread()
.getContextClassLoader();
- @SuppressWarnings("unchecked")
- // incorrect cast will be caught below
+ @SuppressWarnings("unchecked") // incorrect cast will
be caught below
final T o = (T) cl.loadClass(className).newInstance();
if (!clazz.isAssignableFrom(o.getClass())) {
Modified:
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java
URL:
http://svn.apache.org/viewvc/creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java?rev=1617389&r1=1617388&r2=1617389&view=diff
==============================================================================
---
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java
(original)
+++
creadur/rat/trunk/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java
Tue Aug 12 01:08:49 2014
@@ -62,8 +62,7 @@ import org.codehaus.doxia.sink.Sink;
/**
* Generates a report with Rat's output.
*/
-// MavenReport.java induces the deprecated Sink implementation
-@SuppressWarnings("deprecation")
+@SuppressWarnings("deprecation") // MavenReport invokes the deprecated Sink
implementation
@Mojo(name = "rat", requiresDependencyResolution = ResolutionScope.TEST)
public class RatReportMojo extends AbstractRatMojo implements MavenReport
{
