This is an automated email from the ASF dual-hosted git repository. pottlinger pushed a commit to branch feature/RAT-369_maxAllowedViolations in repository https://gitbox.apache.org/repos/asf/creadur-rat.git
commit a6feb80ba3b1796f35a2474e9ff37f1b9071adae Author: P. Ottlinger <[email protected]> AuthorDate: Sat May 11 21:09:21 2024 +0200 RAT-369: Let the build fail in case of new violations/spotbugs errors --- pom.xml | 4 ++-- src/changes/changes.xml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index f96930b0..5e17dc6b 100644 --- a/pom.xml +++ b/pom.xml @@ -320,8 +320,8 @@ agnostic home for software distribution comprehension and audit tools. <artifactId>spotbugs-maven-plugin</artifactId> <version>4.8.5.0</version> <configuration> - <!-- RAT-369: as spotbugs does not allow setting a global (numeric) threshold of currently accepted errors/bugs we do not fail the build --> - <failOnError>false</failOnError> + <maxAllowedViolations>63</maxAllowedViolations> + <failOnError>true</failOnError> <!-- we only want to see our own problems and in all subpackages --> <onlyAnalyze>org.apache.rat.-</onlyAnalyze> <!-- in order to have a global spotbugs configuration an exclusion file needs to exist in all submodules --> diff --git a/src/changes/changes.xml b/src/changes/changes.xml index f9c67341..77b9cbf2 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -85,8 +85,8 @@ https://maven.apache.org/plugins/maven-changes-plugin/xsd/changes-1.0.0.xsd <action issue="RAT-314" type="add" dev="pottlinger"> Add integration test for new default exclude .mvn, that was introduced with v0.16. </action> - <action issue="RAT-366" type="add" dev="pottlinger"> - Integrate checkstyle and spotbugs into the build and webpage generation. Most charset-related errors cannot be fixed until we break JDK8-compliance and move to newer versions. + <action issue="RAT-369" type="add" dev="pottlinger"> + Integrate checkstyle and spotbugs into the build and webpage generation. Most charset-related errors cannot be fixed until we break JDK8-compliance and move to newer versions. Configured a maximum of allowed bugs to fail the build if new errors are introduced. </action> <action issue="RAT-301" type="fix" dev="pottlinger" due-to="claudenw"> Chinese characters in comments are not classified as binary anymore (due to Tika integration).
