tisonkun commented on code in PR #256: URL: https://github.com/apache/curator/pull/256#discussion_r1223017220
########## curator-x-discovery/src/main/java/org/apache/curator/x/discovery/DiscoveryPathConstructor.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.curator.x.discovery; + +/** + * Constructs ZooKeeper paths to services for service discovering. + */ +public interface DiscoveryPathConstructor { + /** + * Return the path where all service names registered. + * + * @return the base path of all services + */ + String getBasePath(); + + /** + * Return the path where all instances of the service registered. + * + * @param serviceName service name + * @return path to service instances + */ + String getPathForInstances(String serviceName); + + /** + * Return the path where specified instance registered. + * + * @param serviceName service name + * @param instanceId instance id + * @return path to concrete instance + */ + String getPathForInstance(String serviceName, String instanceId); Review Comment: > From javadocs, I concludes to "/base-path/{serviceName}/instance-dir/{instanceId}" No. This is an extension point that users can customize arbitrarily. The discussion happened on the JIRA ticket. You can check it out - https://issues.apache.org/jira/browse/CURATOR-457 And I'm OK to postpone this ticket unless anyone shows a real-world use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
