kezhuw commented on code in PR #473:
URL: https://github.com/apache/curator/pull/473#discussion_r1286047013
##########
curator-x-discovery/src/test/java/org/apache/curator/x/discovery/details/TestServiceDiscovery.java:
##########
@@ -261,6 +262,49 @@ public void testBasic() throws Exception {
}
}
+ private static class CustomPathConstructor implements
DiscoveryPathConstructor {
+ @Override
+ public String getBasePath() {
+ return "/test";
+ }
+
+ @Override
+ public String getPathForInstances(String serviceName) {
+ return String.format("/test/%s/instances", serviceName);
+ }
Review Comment:
This fulfill the jira request.
> Right now paths for services in service discovery hardcoded to pattern:
/{basePath} /{serviceName}/{instanceId}. And that's impossible to configure
paths this way: /{basePathPart1} /{serviceName}/{basePathPart2}/{instanceId}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]