kezhuw commented on code in PR #485:
URL: https://github.com/apache/curator/pull/485#discussion_r1354605771
##########
curator-client/pom.xml:
##########
@@ -62,12 +62,6 @@
<artifactId>slf4j-api</artifactId>
</dependency>
- <dependency>
- <groupId>org.mockito</groupId>
- <artifactId>mockito-core</artifactId>
- <scope>test</scope>
- </dependency>
Review Comment:
I am positive to this. I prefer real classes than mocks in most cases if not
all. I do believe mock could provide "clean" tests, but the "clean" part could
lost effect in refactor comparing to stupid/verbose/explicit hooks. Also, I am
fearing about tests full of mocks. Removing this will force us to think about
testability. That is good for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
