HoustonPutman commented on code in PR #513:
URL: https://github.com/apache/curator/pull/513#discussion_r1892384239
##########
curator-framework/src/main/java/org/apache/curator/framework/imps/GetChildrenBuilderImpl.java:
##########
@@ -165,14 +165,15 @@ public void performBackgroundOperation(final
OperationAndData<String> operationA
@Override
public void processResult(int rc, String path, Object o,
List<String> strings, Stat stat) {
watching.commitWatcher(rc, false);
+ if (strings == null) {
+ strings = Lists.newArrayList();
+ }
Review Comment:
I'm actually reverting this change, since I was just moving the call up a
few lines. When creating the `CuratorEventImpl`, `strings` was already made to
be non-null, so I didn't want to undo that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]