HoustonPutman commented on code in PR #514:
URL: https://github.com/apache/curator/pull/514#discussion_r1924124768
##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java:
##########
@@ -445,6 +447,18 @@ public void close() {
unhandledErrorListeners.clear();
connectionStateManager.close();
client.close();
+
+ if (asyncWatchService != null) {
Review Comment:
`after publishing the close event`.
That would happen either after `connectionStateManager.close()` or
`client.close()`. So this is happening just after those are called.
But I do think we would want to skip any client connection management
watches here. Those probably shouldn't be asynchronous anyways. So I'm going to
look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
