kotman12 commented on PR #1250:
URL: https://github.com/apache/curator/pull/1250#issuecomment-2737229573
Hey .. I just did a walk-through of the code again and have a question. Is
applying the filter:
```
e -> !e.getKey().isRoot()
&&
e.getKey().parent().equals(client.modelSpec().path())
```
safe to do from `::list()`? I realize I added that behavior by deferring to
the newly created `internalChildren` from within `list` which applies this
filter that wasn't applied before. I am worried this is a regression not caught
by the tests.
If it is ok then it is probably ok to remove the now unused methods in
`ModeledCachedImpl:
```
ZPath basePath() {
return basePath;
}
Map<ZPath, ZNode<T>> currentChildren() {
return currentChildren(basePath);
}
```
Either way I think a change is due ... let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
