Copilot commented on code in PR #1273:
URL: https://github.com/apache/curator/pull/1273#discussion_r2256991102


##########
curator-test/src/main/java/org/apache/curator/test/ZooKeeperServerEmbeddedAdapter.java:
##########
@@ -98,8 +98,9 @@ private boolean hijackClientPort(int port) {
                 addressField.set(peerConfig, new InetSocketAddress(port));
                 return true;
             }
-        } catch (Exception ignored) {
+        } catch (Exception e) {
             // swallow hijack failure to accommodate possible upstream changes
+            log.debug("Failed to hijack client port configuration, this may be 
due to upstream changes", e);

Review Comment:
   The error message contains a grammatical error. It should be "Failed to 
hijack client port configuration; this may be due to upstream changes" (add 
semicolon) or "Failed to hijack client port configuration. This may be due to 
upstream changes" (use period and capitalize 'This').
   ```suggestion
               log.debug("Failed to hijack client port configuration. This may 
be due to upstream changes", e);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to