QiuYucheng2003 opened a new issue, #1282:
URL: https://github.com/apache/curator/issues/1282
### Description
The LeaderSelector class provides a convenience constructor that implicitly
creates an internal ExecutorService using Executors.newSingleThreadExecutor().
### Code Reference In
org.apache.curator.framework.recipes.leader.LeaderSelector (Line 104):
public LeaderSelector(CuratorFramework client, String leaderPath,
LeaderSelectorListener listener) {
this(
client,
leaderPath,
// Issue: Implicitly creates a thread pool that is hidden from
the user
new
CloseableExecutorService(Executors.newSingleThreadExecutor(defaultThreadFactory),
true),
listener);
}
### The Issue
1. Hidden Lifecycle: Users utilizing this constructor may not be aware that
a heavy resource (Thread Pool) is created internally.
2. Thread Leak Risk: If the LeaderSelector instance is garbage collected
without calling close() (e.g., during rapid Zookeeper session reconstruction or
error handling flows), the internal non-daemon thread pool remains active. This
leads to Thread Leaks and eventual OutOfMemoryError or thread exhaustion.
### Recommendation
Deprecate this constructor to discourage implicit resource allocation.
Or, update Javadoc to explicitly warn users that close() is mandatory to
release the internal threads.
Ideally, encourage Dependency Injection where the ExecutorService is passed
externally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
