waterWang opened a new pull request, #1300:
URL: https://github.com/apache/curator/pull/1300
## Description
When `abortOperation` is called for a retriable error and no
`BackgroundCallback` was specified on the operation, the `CuratorListener` was
silently ignored (the method returned early at `if (operation.getCallback() ==
null) { return; }`).
According to the documented behavior, `CuratorListener` is a catch-all
fallback for `BackgroundCallback` when no callback is specified at the
operation level. This fix ensures that the `CuratorListener` is properly
notified via `processEvent()` in this case.
## Changes
In `CuratorFrameworkImpl.abortOperation()`:
- Moved the callback-null check after the event creation
- When `callback == null`, call `processEvent(event)` to notify all
registered `CuratorListener` instances
- When `callback != null`, continue to call
`sendToBackgroundCallback(operation, event)` as before
Fixes #1191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
