Author: bharath
Date: Fri Feb 6 10:45:51 2009
New Revision: 741521
URL: http://svn.apache.org/viewvc?rev=741521&view=rev
Log:
After purging acknowledged messages, if there are not more unacknowledges
messsages for the given sequence, we completely remove the map entry for the
sequence from the ResendCandidates map. The removal operation was buggy - The
correct key was not being passed to the map remove method. As a result of this,
the entry would forever stay in the map. Fixed this.
Also added a new test case for this.
RetransmissionQueueImplTest#testPurgeAcknowledgedAll()
Modified:
cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
Modified:
cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java?rev=741521&r1=741520&r2=741521&view=diff
==============================================================================
---
cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
(original)
+++
cxf/trunk/rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/soap/RetransmissionQueueImpl.java
Fri Feb 6 10:45:51 2009
@@ -133,7 +133,7 @@
}
}
if (sequenceCandidates.isEmpty()) {
- candidates.remove(seq.getIdentifier());
+ candidates.remove(seq.getIdentifier().getValue());
}
LOG.fine("Completed purging resend candidates.");
}