svn commit: r1053059 - in /cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings: SettingsPresenter.java SubscriptionDialogImpl.java

[tomekopo]

Author: tomekopo
Date: Mon Dec 27 12:52:31 2010
New Revision: 1053059

URL: http://svn.apache.org/viewvc?rev=1053059&view=rev
Log:
Fix bug: validation errors are not hidden in some situations

Modified:
    
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SettingsPresenter.java
    
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SubscriptionDialogImpl.java

Modified: 
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SettingsPresenter.java
URL: 
http://svn.apache.org/viewvc/cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SettingsPresenter.java?rev=1053059&r1=1053058&r2=1053059&view=diff
==============================================================================
--- 
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SettingsPresenter.java
 (original)
+++ 
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SettingsPresenter.java
 Mon Dec 27 12:52:31 2010
@@ -149,12 +149,12 @@ public class SettingsPresenter extends B
         Map<HasValue, String> errors = new HashMap<HasValue, String>();
 
         String nameValue = name.getValue();
-        if (nameValue == null || "".equals(nameValue)) {
+        if (nameValue == null || nameValue.isEmpty()) {
             errors.put(name, 
constans.settingsTabSubscriptionDialogEmptyName());
         }
 
         String urlValue = url.getValue();
-        if (urlValue == null || "".equals(urlValue)) {
+        if (urlValue == null || urlValue.isEmpty()) {
             errors.put(url, constans.settingsTabSubscriptionDialogEmptyUrl());
         }
 

Modified: 
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SubscriptionDialogImpl.java
URL: 
http://svn.apache.org/viewvc/cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SubscriptionDialogImpl.java?rev=1053059&r1=1053058&r2=1053059&view=diff
==============================================================================
--- 
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SubscriptionDialogImpl.java
 (original)
+++ 
cxf/sandbox/logbrowser/rt/management-web/src/main/java/org/apache/cxf/management/web/logging/logbrowser/client/ui/settings/SubscriptionDialogImpl.java
 Mon Dec 27 12:52:31 2010
@@ -76,9 +76,10 @@ public class SubscriptionDialogImpl exte
     } 
 
     public void setValidationErrors(@Nullable Map<HasValue, String> errors) {
+        form.nameErrorLabel.setVisible(false);
+        form.urlErrorLabel.setVisible(false);
+        
         if (errors == null) {
-            form.nameErrorLabel.setVisible(false);
-            form.urlErrorLabel.setVisible(false);
             return;
         }