Author: dkulp
Date: Tue Jan 31 22:40:42 2012
New Revision: 1238842
URL: http://svn.apache.org/viewvc?rev=1238842&view=rev
Log:
Fix some minor SONAR issues mostly so I can say I actually accomplished
something useful today. :-) (or :-( )
Modified:
cxf/trunk/api/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java
cxf/trunk/rt/core/src/main/java/org/apache/cxf/catalog/OASISCatalogManager.java
cxf/trunk/rt/databinding/sdo/src/main/java/org/apache/cxf/sdo/DataReaderImpl.java
cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/DataWriterImpl.java
cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/DigestAuthSupplier.java
cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/common/ProcessorTestBase.java
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToCorbaHelper.java
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLTypes.java
Modified:
cxf/trunk/api/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/api/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
--- cxf/trunk/api/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
(original)
+++ cxf/trunk/api/src/main/java/org/apache/cxf/common/logging/JDKBugHacks.java
Tue Jan 31 22:40:42 2012
@@ -72,7 +72,7 @@ final class JDKBugHacks {
try {
cname = din.readLine();
if (cname != null) {
- cname.trim();
+ cname = cname.trim();
}
} finally {
din.close();
Modified:
cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
(original)
+++
cxf/trunk/integration/jca/src/main/java/org/apache/cxf/jca/outbound/CXFConnectionSpec.java
Tue Jan 31 22:40:42 2012
@@ -152,11 +152,11 @@ public class CXFConnectionSpec implement
int retval = 0;
if (wsdlURL != null) {
- retval += wsdlURL.hashCode();
+ retval += wsdlURL.hashCode(); //NOSONAR
}
if (busConfigURL != null) {
- retval += busConfigURL.hashCode();
+ retval += busConfigURL.hashCode(); //NOSONAR
}
if (serviceClass != null) {
Modified:
cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java
(original)
+++
cxf/trunk/rt/bindings/corba/src/main/java/org/apache/cxf/binding/corba/runtime/CorbaObjectReader.java
Tue Jan 31 22:40:42 2012
@@ -241,7 +241,7 @@ public class CorbaObjectReader {
long l2 = l & 0x7FFFFFFFFFFFFFL;
BigInteger i = BigInteger.valueOf(l2);
BigInteger i2 = BigInteger.valueOf(0);
- i2.setBit(63);
+ i2 = i2.setBit(63);
i = i.or(i2);
return i;
}
Modified:
cxf/trunk/rt/core/src/main/java/org/apache/cxf/catalog/OASISCatalogManager.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/rt/core/src/main/java/org/apache/cxf/catalog/OASISCatalogManager.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/rt/core/src/main/java/org/apache/cxf/catalog/OASISCatalogManager.java
(original)
+++
cxf/trunk/rt/core/src/main/java/org/apache/cxf/catalog/OASISCatalogManager.java
Tue Jan 31 22:40:42 2012
@@ -22,6 +22,7 @@ import java.io.File;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.net.MalformedURLException;
+import java.net.URI;
import java.net.URISyntaxException;
import java.net.URL;
import java.util.Collections;
@@ -53,7 +54,7 @@ public class OASISCatalogManager {
private Object resolver;
- private Set<URL> loadedCatalogs = Collections.synchronizedSet(new
HashSet<URL>());
+ private Set<URI> loadedCatalogs = Collections.synchronizedSet(new
HashSet<URI>());
private Bus bus;
public OASISCatalogManager() {
@@ -114,15 +115,15 @@ public class OASISCatalogManager {
Enumeration<URL> catalogs = classLoader.getResources(name);
while (catalogs.hasMoreElements()) {
URL catalogURL = catalogs.nextElement();
- if (!loadedCatalogs.contains(catalogURL)) {
+ if (!loadedCatalogs.contains(URI.create(catalogURL.toString()))) {
((Catalog)resolver).parseCatalog(catalogURL);
- loadedCatalogs.add(catalogURL);
+ loadedCatalogs.add(URI.create(catalogURL.toString()));
}
}
}
public final void loadCatalog(URL catalogURL) throws IOException {
- if (!loadedCatalogs.contains(catalogURL) && resolver != null) {
+ if (!loadedCatalogs.contains(URI.create(catalogURL.toString())) &&
resolver != null) {
if ("file".equals(catalogURL.getProtocol())) {
try {
File file = new File(catalogURL.toURI());
@@ -136,7 +137,7 @@ public class OASISCatalogManager {
((Catalog)resolver).parseCatalog(catalogURL);
- loadedCatalogs.add(catalogURL);
+ loadedCatalogs.add(URI.create(catalogURL.toString()));
}
}
Modified:
cxf/trunk/rt/databinding/sdo/src/main/java/org/apache/cxf/sdo/DataReaderImpl.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/sdo/src/main/java/org/apache/cxf/sdo/DataReaderImpl.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/rt/databinding/sdo/src/main/java/org/apache/cxf/sdo/DataReaderImpl.java
(original)
+++
cxf/trunk/rt/databinding/sdo/src/main/java/org/apache/cxf/sdo/DataReaderImpl.java
Tue Jan 31 22:40:42 2012
@@ -64,7 +64,7 @@ public class DataReaderImpl implements D
return o;
} catch (Exception e) {
- new Fault(e);
+ throw new Fault(e);
}
}
return null;
Modified:
cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/DataWriterImpl.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/DataWriterImpl.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/DataWriterImpl.java
(original)
+++
cxf/trunk/rt/databinding/xmlbeans/src/main/java/org/apache/cxf/xmlbeans/DataWriterImpl.java
Tue Jan 31 22:40:42 2012
@@ -48,7 +48,6 @@ import org.apache.cxf.message.Message;
import org.apache.cxf.message.MessageUtils;
import org.apache.cxf.service.model.MessagePartInfo;
import org.apache.cxf.staxutils.StaxUtils;
-import org.apache.ws.commons.schema.XmlSchemaAnnotated;
import org.apache.ws.commons.schema.XmlSchemaElement;
import org.apache.xmlbeans.SchemaType;
import org.apache.xmlbeans.XmlAnySimpleType;
@@ -75,8 +74,6 @@ public class DataWriterImpl implements D
if (typeClass == null) {
typeClass = obj.getClass();
}
- XmlSchemaAnnotated schemaType = part == null ? null :
part.getXmlSchema();
-
if (!XmlObject.class.isAssignableFrom(typeClass) && part != null) {
typeClass =
(Class<?>)part.getProperty(XmlAnySimpleType.class.getName());
@@ -103,8 +100,7 @@ public class DataWriterImpl implements D
}
- if (obj != null
- || !(schemaType instanceof XmlSchemaElement)) {
+ if (obj != null) {
XmlOptions options = new XmlOptions();
if (schema != null) {
options.setValidateOnSet();
Modified:
cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/DigestAuthSupplier.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/DigestAuthSupplier.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/DigestAuthSupplier.java
(original)
+++
cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/auth/DigestAuthSupplier.java
Tue Jan 31 22:40:42 2012
@@ -20,6 +20,7 @@
package org.apache.cxf.transport.http.auth;
import java.io.UnsupportedEncodingException;
+import java.net.URI;
import java.net.URL;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
@@ -39,7 +40,7 @@ public class DigestAuthSupplier implemen
};
final MessageDigest md5Helper;
- Map<URL, DigestInfo> authInfo = new ConcurrentHashMap<URL, DigestInfo>();
+ Map<URI, DigestInfo> authInfo = new ConcurrentHashMap<URI, DigestInfo>();
public DigestAuthSupplier() {
MessageDigest md = null;
@@ -64,8 +65,9 @@ public class DigestAuthSupplier implemen
URL currentURL,
Message message,
String fullHeader) {
+ URI currentURI = URI.create(currentURL.toString());
if (fullHeader == null) {
- DigestInfo di = authInfo.get(currentURL);
+ DigestInfo di = authInfo.get(currentURI);
if (di != null) {
/* Preemptive authentication is only possible if we have a
cached
* challenge
@@ -97,7 +99,7 @@ public class DigestAuthSupplier implemen
if (di.method == null) {
di.method = "POST";
}
- authInfo.put(currentURL, di);
+ authInfo.put(currentURI, di);
return di.generateAuth(currentURL.getFile(),
authPolicy.getUserName(),
Modified:
cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/common/ProcessorTestBase.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/common/ProcessorTestBase.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/common/ProcessorTestBase.java
(original)
+++
cxf/trunk/tools/common/src/main/java/org/apache/cxf/tools/common/ProcessorTestBase.java
Tue Jan 31 22:40:42 2012
@@ -222,7 +222,7 @@ public class ProcessorTestBase extends A
throw new ComparisonFailure("Attributes not equal: ",
attr.getKey() + ":" +
attr.getValue(),
attr.getKey() + ":"
- +
sourceTag.getAttributes().get(attr.getKey()).toString());
+ +
sourceTag.getAttributes().get(attr.getKey()));
}
} else {
throw new AssertionError("Attribute: " + attr + " is
missing in the source file.");
@@ -232,8 +232,8 @@ public class ProcessorTestBase extends A
if (!StringUtils.isEmpty(expectedTag.getText())
&& !expectedTag.getText().equals(sourceTag.getText())) {
throw new ComparisonFailure("Text not equal: ",
- expectedTag.getText().toString(),
- sourceTag.getText().toString());
+ expectedTag.getText(),
+ sourceTag.getText());
}
}
return true;
@@ -285,8 +285,8 @@ public class ProcessorTestBase extends A
if (!StringUtils.isEmpty(expected.getText())
&& !expected.getText().equals(source.getText())) {
throw new ComparisonFailure("Text not equal: ",
- expected.getText().toString(),
- source.getText().toString());
+ expected.getText(),
+ source.getText());
}
if (!expected.getTags().isEmpty()) {
Modified:
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToCorbaHelper.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToCorbaHelper.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToCorbaHelper.java
(original)
+++
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLToCorbaHelper.java
Tue Jan 31 22:40:42 2012
@@ -585,7 +585,7 @@ public class WSDLToCorbaHelper {
} else {
String msg = "Unsupported Attribute Found in CORBA Binding
Generation:"
+ attrName;
- LOG.log(Level.WARNING, msg.toString());
+ LOG.log(Level.WARNING, msg);
}
}
@@ -908,7 +908,7 @@ public class WSDLToCorbaHelper {
if (!anonymous) {
String msg = "Couldn't Map to Array:" + name +
":minOccurs="
+ minOccurs + ":maxOccurs=" + maxOccurs;
- LOG.log(Level.WARNING, msg.toString());
+ LOG.log(Level.WARNING, msg);
return null;
} else {
return WSDLTypes.mapToArray(name,
checkPrefix(schematypeName), arrayType,
@@ -1418,7 +1418,7 @@ public class WSDLToCorbaHelper {
caselist.add("TRUE");
} else {
String msg = "Discriminator Type doesnt match number of
Choices in Union:" + name;
- LOG.log(Level.WARNING, msg.toString());
+ LOG.log(Level.WARNING, msg);
}
}
}
Modified:
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLTypes.java
URL:
http://svn.apache.org/viewvc/cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLTypes.java?rev=1238842&r1=1238841&r2=1238842&view=diff
==============================================================================
---
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLTypes.java
(original)
+++
cxf/trunk/tools/corba/src/main/java/org/apache/cxf/tools/corba/processors/wsdl/WSDLTypes.java
Tue Jan 31 22:40:42 2012
@@ -84,7 +84,7 @@ public final class WSDLTypes {
Node node = nlist.item(0);
String info = node.getNodeValue();
- info.trim();
+ info = info.trim();
if ("corba:binding=".equals(info.substring(0, 14))) {
String bindingName = info.substring(14);
