Repository: cxf-fediz Updated Branches: refs/heads/master b4c5845c7 -> 1b86b130b
Use StringBuilder instead of StringBuffer Project: http://git-wip-us.apache.org/repos/asf/cxf-fediz/repo Commit: http://git-wip-us.apache.org/repos/asf/cxf-fediz/commit/68f18ae8 Tree: http://git-wip-us.apache.org/repos/asf/cxf-fediz/tree/68f18ae8 Diff: http://git-wip-us.apache.org/repos/asf/cxf-fediz/diff/68f18ae8 Branch: refs/heads/master Commit: 68f18ae86c2d0db0352fb142b2751c34ed952137 Parents: 202f08f Author: Colm O hEigeartaigh <[email protected]> Authored: Mon Mar 10 16:52:47 2014 +0000 Committer: Colm O hEigeartaigh <[email protected]> Committed: Mon Mar 10 16:52:47 2014 +0000 ---------------------------------------------------------------------- .../org/apache/cxf/fediz/core/AbstractSAMLCallbackHandler.java | 2 +- .../org/apache/cxf/fediz/service/idp/FederationEntryPoint.java | 2 +- .../service/idp/protocols/TrustedIdpWSFedProtocolHandler.java | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cxf-fediz/blob/68f18ae8/plugins/core/src/test/java/org/apache/cxf/fediz/core/AbstractSAMLCallbackHandler.java ---------------------------------------------------------------------- diff --git a/plugins/core/src/test/java/org/apache/cxf/fediz/core/AbstractSAMLCallbackHandler.java b/plugins/core/src/test/java/org/apache/cxf/fediz/core/AbstractSAMLCallbackHandler.java index 267587a..3ff69f0 100644 --- a/plugins/core/src/test/java/org/apache/cxf/fediz/core/AbstractSAMLCallbackHandler.java +++ b/plugins/core/src/test/java/org/apache/cxf/fediz/core/AbstractSAMLCallbackHandler.java @@ -273,7 +273,7 @@ public abstract class AbstractSAMLCallbackHandler implements CallbackHandler { attributeBean.addAttributeValue(role); } } else { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); for (String role: roles) { sb.append(role).append(this.roleSeperator); } http://git-wip-us.apache.org/repos/asf/cxf-fediz/blob/68f18ae8/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/FederationEntryPoint.java ---------------------------------------------------------------------- diff --git a/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/FederationEntryPoint.java b/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/FederationEntryPoint.java index c5d5cf1..c7265a1 100644 --- a/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/FederationEntryPoint.java +++ b/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/FederationEntryPoint.java @@ -97,7 +97,7 @@ public class FederationEntryPoint implements AuthenticationEntryPoint, response.sendError( HttpServletResponse.SC_INTERNAL_SERVER_ERROR, "wauth value '" + wauth + "' not supported"); } - redirectUrl = new StringBuffer(extractFullContextPath(servletRequest)) + redirectUrl = new StringBuilder(extractFullContextPath(servletRequest)) .append(realm).append(loginUri).toString(); preCommence(servletRequest, response); http://git-wip-us.apache.org/repos/asf/cxf-fediz/blob/68f18ae8/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/protocols/TrustedIdpWSFedProtocolHandler.java ---------------------------------------------------------------------- diff --git a/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/protocols/TrustedIdpWSFedProtocolHandler.java b/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/protocols/TrustedIdpWSFedProtocolHandler.java index 64a158c..b572af7 100644 --- a/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/protocols/TrustedIdpWSFedProtocolHandler.java +++ b/services/idp/src/main/java/org/apache/cxf/fediz/service/idp/protocols/TrustedIdpWSFedProtocolHandler.java @@ -88,7 +88,7 @@ public class TrustedIdpWSFedProtocolHandler implements TrustedIdpProtocolHandler public URL mapSignInRequest(RequestContext context, Idp idp, TrustedIdp trustedIdp) { try { - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append(trustedIdp.getUrl()); sb.append("?").append(FederationConstants.PARAM_ACTION).append('='); sb.append(FederationConstants.ACTION_SIGNIN);
