Repository: cxf Updated Branches: refs/heads/master f912f16cf -> db2f02a91
"Fix" a checkstyle error Project: http://git-wip-us.apache.org/repos/asf/cxf/repo Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/db2f02a9 Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/db2f02a9 Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/db2f02a9 Branch: refs/heads/master Commit: db2f02a91c7a9fb7ef88c34475f8a97d46a7ffad Parents: f912f16 Author: Daniel Kulp <[email protected]> Authored: Thu Jun 12 13:21:41 2014 -0400 Committer: Daniel Kulp <[email protected]> Committed: Thu Jun 12 13:21:41 2014 -0400 ---------------------------------------------------------------------- .../WebSocketVirtualServletResponse.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cxf/blob/db2f02a9/rt/transports/websocket/src/main/java/org/apache/cxf/transport/websocket/WebSocketVirtualServletResponse.java ---------------------------------------------------------------------- diff --git a/rt/transports/websocket/src/main/java/org/apache/cxf/transport/websocket/WebSocketVirtualServletResponse.java b/rt/transports/websocket/src/main/java/org/apache/cxf/transport/websocket/WebSocketVirtualServletResponse.java index d1fa3b1..5bd6e7c 100644 --- a/rt/transports/websocket/src/main/java/org/apache/cxf/transport/websocket/WebSocketVirtualServletResponse.java +++ b/rt/transports/websocket/src/main/java/org/apache/cxf/transport/websocket/WebSocketVirtualServletResponse.java @@ -307,16 +307,16 @@ public class WebSocketVirtualServletResponse implements HttpServletResponse { } private ServletOutputStream createOutputStream() { + //REVISIT + // This output buffering is needed as the server side websocket does + // not support the fragment transmission mode when sending back a large data. + // And this buffering is only used for the response for the initial service innovation. + // For the subsequently pushed data to the socket are sent back + // unbuffered as individual websocket messages. + // the things to consider : + // - provide a size limit if we are use this buffering + // - add a chunking mode in the cxf websocket's binding. return new ServletOutputStream() { - //REVISIT - // This output buffering is needed as the server side websocket does - // not support the fragment transmission mode when sending back a large data. - // And this buffering is only used for the response for the initial service innovation. - // For the subsequently pushed data to the socket are sent back - // unbuffered as individual websocket messages. - // the things to consider : - // - provide a size limit if we are use this buffering - // - add a chunking mode in the cxf websocket's binding. private InternalByteArrayOutputStream buffer = new InternalByteArrayOutputStream(); @Override
